Add '3d' feature to allow excluding bevy_pbr - #62
Merged
Conversation
Contributor
Author
|
how to fix the rustdoc warning 🤔 |
mgi388
approved these changes
Jan 11, 2026
mgi388
left a comment
mgi388
left a comment
Contributor
There was a problem hiding this comment.
I haven't tested or reviewed the code thoroughly, but I'm in favor of the general idea of reintroducing the 3d feature again. I actually use the 3d feature myself so this PR doesn't directly affect me, but if I was building a 2D game, I'd 100% want to remove bevy_pbr (and its dependents).
Contributor
|
It could be worth revisiting this PR after doing the Bevy 0.18 upgrade. The new feature collections could be relevant here. |
Merged
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #60